Remove success field from logging-set-level JSON output#48
Merged
Conversation
Remove the `success: true` field from `logging-set-level` JSON output, aligning it with the project convention of indicating errors via exit codes rather than wrapping responses in a success field. https://claude.ai/code/session_01TaCYsayZaZcijd3K2QZXVo
The bridge was not registering a handler for LoggingMessageNotification, so server log messages were silently dropped. Register the handler on the SDK client after connection and broadcast to IPC clients, making logging-set-level actually observable in the interactive shell. https://claude.ai/code/session_01TaCYsayZaZcijd3K2QZXVo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified the JSON output format for the
logging-set-levelcommand to align with the project's convention of using exit codes to indicate errors rather than including asuccessfield in the response.Changes
success: truefield from the JSON output ofsetLogLevel()command{"level":"<level>","success":true}to{"level":"<level>"}for consistency with project conventionsformatOutput()call by removing unnecessary object propertiesDetails
The change reflects the project's design principle that command success/failure should be communicated through exit codes rather than response body fields. This makes the JSON output cleaner and more consistent across the CLI interface.
https://claude.ai/code/session_01TaCYsayZaZcijd3K2QZXVo