Add color formatting to keychain unavailable warning#67
Merged
Conversation
The OS keychain fallback warning was printed without any color styling, making it easy to miss. Wrap the message in chalk.red() so it stands out in human mode. https://claude.ai/code/session_01G22KezC4Uhfxzse1md3Gi9
…log policy Remove the changelog entry for the red keychain warning (too minor). Update CLAUDE.md to explicitly exclude minor cosmetic/styling tweaks from changelog requirements. https://claude.ai/code/session_01G22KezC4Uhfxzse1md3Gi9
Make it explicit that lint must pass before committing, never be skipped, and point to lint:fix for auto-fixing. https://claude.ai/code/session_01G22KezC4Uhfxzse1md3Gi9
Update CLAUDE.md to mandate running npm test and fixing failures before committing. Add chalk mock to keychain test to fix ESM subpath import error under Jest. https://claude.ai/code/session_01G22KezC4Uhfxzse1md3Gi9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds visual emphasis to the OS keychain unavailability warning message by wrapping it with red color formatting using the
chalklibrary.Changes
chalklibrary insrc/lib/auth/keychain.tschalk.red()to display it in red text, making the warning more visually prominent to usersCLAUDE.mdto clarify that minor cosmetic/styling changes (like color adjustments) should not require changelog entriesImplementation Details
The warning message is only colored when the keychain is unavailable and JSON mode is not enabled, preserving the existing conditional logic while improving the visual presentation of this important warning to users.
https://claude.ai/code/session_01G22KezC4Uhfxzse1md3Gi9