Convert x402 sign command to use positional argument#69
Merged
Conversation
The PAYMENT-REQUIRED header is the only required input for the sign command, so a positional argument is simpler and less redundant than a required option flag. https://claude.ai/code/session_018NNkSjHsJrLhG1cAgdmdvY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
x402 signcommand to accept the PAYMENT-REQUIRED header as a positional argument instead of a required-rflag, improving the command's usability and consistency with CLI conventions.Key Changes
x402 signcommand signature fromsign -r <base64>tosign <payment-required>-r, --payment-requiredrequired option to a positional argument parameterpaymentRequiredas the first parameter instead of accessing it fromopts-rand--payment-requiredfrom theOPTIONS_WITH_VALUESparser configurationImplementation Details
paymentRequired, eliminating the need for the-rflag--amount,--expiry) remain as optional flagshttps://claude.ai/code/session_018NNkSjHsJrLhG1cAgdmdvY