Add progress notification support to async tool execution#71
Merged
Conversation
The --async flag spinner now shows messages from MCP progress notifications (notifications/progress) in addition to task status messages. This uses the SDK's onprogress callback to capture the message field from progress notifications and display it in the spinner alongside elapsed time. https://claude.ai/code/session_013XT1MvJMo5zMkg9koyBLqr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for progress notifications during async tool execution, allowing tools to report progress updates (progress value, total, and messages) that are displayed in the CLI spinner alongside elapsed time and status messages.
Key Changes
MCP Client (
src/core/mcp-client.ts)onprogresscallback handler that converts progress notifications intoTaskUpdateobjects with progress metadataonprogresshandler to thecallToolStreamrequest options whenonUpdatecallback is providedcurrentTaskIdandcurrentStatuswhen task creation and status messages are receivedCLI Tools Command (
src/cli/commands/tools.ts)lastProgressMessagetracking separate fromlastStatusMessageprogressMessagefrom task updates in the spinnerType Definitions (
src/lib/types.ts)TaskUpdateinterface with three new optional fields:progressMessage: Message from progress notificationsprogress: Current progress valueprogressTotal: Total progress value for percentage calculationsDocumentation (
CHANGELOG.md)Implementation Details
The progress notification flow works by:
onprogresscallbackTaskUpdateobjects that include progress metadataonUpdatecallback mechanismhttps://claude.ai/code/session_013XT1MvJMo5zMkg9koyBLqr