Remove redundant success field from logging set-level JSON output#74
Merged
Remove redundant success field from logging set-level JSON output#74
Conversation
The JSON output convention (per CLAUDE.md) is to indicate success via exit codes, not a `success` wrapper field. Remove it from the logging-set-level command's JSON output. https://claude.ai/code/session_01RgrSu5dW8zFrroHJLjCUdZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified the JSON output format for the
logging-set-levelcommand by removing the redundantsuccessfield. The output now only includes thelevelfield, making the response more concise and focused.Changes
success: truefield from the JSON output insetLogLevel()commandformatOutput()call to only include thelevelpropertyDetails
The
successfield was redundant in the JSON response since the command either succeeds (and returns the output) or fails (and throws an error). By removing this field, the JSON output is now cleaner and more aligned with REST API conventions where the presence of a successful response implies success.https://claude.ai/code/session_01RgrSu5dW8zFrroHJLjCUdZ