Fix OAuth token refresh for servers with root-based discovery (fixes #3)#6
Closed
kingsleyzhong wants to merge 2 commits intoapify:mainfrom
Closed
Fix OAuth token refresh for servers with root-based discovery (fixes #3)#6kingsleyzhong wants to merge 2 commits intoapify:mainfrom
kingsleyzhong wants to merge 2 commits intoapify:mainfrom
Conversation
Fixes apify#3 The discoverTokenEndpoint() function only tried path-based OAuth discovery URLs (e.g., https://mcp.notion.com/mcp/.well-known/oauth-authorization-server), but some servers like Notion host their OAuth metadata at the root (e.g., https://mcp.notion.com/.well-known/oauth-authorization-server). Initial login worked because discoverAuthorizationServerMetadata() in the MCP SDK tries both path-based and root-based discovery. However, token refresh failed because discoverTokenEndpoint() only tried path-based URLs. This fix adds root-based fallback URLs to discoverTokenEndpoint(), matching the behavior of the MCP SDK's discovery function.
Will regenerate this later
Member
|
Great catch, thanks for the fix - I was unable to revert the changes to package-lock.json, so I recreated the changes in c69008a |
5 tasks
jancurn
pushed a commit
that referenced
this pull request
Apr 15, 2026
On Windows, `isProcessAlive()` uses a 2-second cached `tasklist` snapshot populated when `stopBridge()` runs. When `restartSession` subsequently spawns a new bridge, the new PID is not in the cache, causing `ensureBridgeReady()` to misclassify the freshly spawned bridge as dead and trigger a spurious double-restart via `restartBridge()`. Unlike the explicit `restartSession` path, `restartBridge` passes `mcpSessionId` for resumption, so the second bridge silently resumes the old MCP session and `sessions.json` never records a new session ID. This caused two E2E tests to fail on Windows: - sessions/mcp-session #6: mcpSessionId unchanged after explicit restart - sessions/restart #9: `.capabilities` missing from `restart --json` Fix by resetting the tasklist cache immediately after spawning the bridge so the next `isProcessAlive()` check runs a fresh `tasklist`. The only `spawn()` call in src/ is in `startBridge`, so one invalidation site covers every bridge startup path. https://claude.ai/code/session_014w5QYdwZKHA5REd2pTEXwP
jancurn
added a commit
that referenced
this pull request
Apr 15, 2026
…167) On Windows, `isProcessAlive()` uses a 2-second cached `tasklist` snapshot populated when `stopBridge()` runs. When `restartSession` subsequently spawns a new bridge, the new PID is not in the cache, causing `ensureBridgeReady()` to misclassify the freshly spawned bridge as dead and trigger a spurious double-restart via `restartBridge()`. Unlike the explicit `restartSession` path, `restartBridge` passes `mcpSessionId` for resumption, so the second bridge silently resumes the old MCP session and `sessions.json` never records a new session ID. This caused two E2E tests to fail on Windows: - sessions/mcp-session #6: mcpSessionId unchanged after explicit restart - sessions/restart #9: `.capabilities` missing from `restart --json` Fix by resetting the tasklist cache immediately after spawning the bridge so the next `isProcessAlive()` check runs a fresh `tasklist`. The only `spawn()` call in src/ is in `startBridge`, so one invalidation site covers every bridge startup path. https://claude.ai/code/session_014w5QYdwZKHA5REd2pTEXwP Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
discoverTokenEndpoint()function inoauth-utils.tsonly tries path-based OAuth discovery URLs:https://example.com/mcp/.well-known/oauth-authorization-serverhttps://example.com/mcp/.well-known/openid-configurationHowever, some servers like Notion host their OAuth metadata at the root:
https://mcp.notion.com/.well-known/oauth-authorization-serverThis causes token refresh to fail for these servers, even though initial login works (because the MCP SDK's
discoverAuthorizationServerMetadata()tries both path-based and root-based discovery).Solution
Add root-based fallback URLs to
discoverTokenEndpoint(), matching the behavior of the MCP SDK:Testing
discoverTokenEndpoint('https://mcp.notion.com/mcp')now correctly returnshttps://mcp.notion.com/tokenFixes #3