Skip to content

fix: add missing resolve() when headers are already send using forward handlers #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bliuchak merged 1 commit into from
Dec 1, 2025
Merged

fix: add missing resolve() when headers are already send using forward handlers #625

bliuchak merged 1 commit into from
Dec 1, 2025

Conversation

@bliuchak
Copy link
Contributor

@bliuchak bliuchak commented Nov 28, 2025

Both forward and forward_socks are affected.

Found this during HTTPS scope split. Based on my investigation, the specific bug condition (client.on('error') firing after response.headersSent is true) appears to not possible to trigger reliably (or it's just my skill issue).

I used resolve() but not reject() to be consistent with pipeline() catch block which also calls resolve().

@bliuchak
fix: add missing resolve() when headers are already send using forwar…
9da03b2 
…d handlers

Both forward and forward_socks are affected.
@bliuchak bliuchak added bug Something isn't working. adhoc Ad-hoc unplanned task added during the sprint. low priority Low priority issues to be done eventually. t-core-services Issues with this label are in the ownership of the core services team. t-unblocking Issues with this label are in the ownership of the unblocking team. labels Nov 28, 2025
jirimoravcik
jirimoravcik approved these changes Nov 29, 2025
View reviewed changes
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you

@bliuchak bliuchak merged commit c585e59 into master Dec 1, 2025
6 of 7 checks passed
@bliuchak bliuchak deleted the fix/promise branch December 1, 2025 09:31
@tobice tobice added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

@lewis-wow lewis-wow Awaiting requested review from lewis-wow

Assignees

@bliuchak bliuchak

Labels

adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. low priority Low priority issues to be done eventually. t-core-services Issues with this label are in the ownership of the core services team. t-unblocking Issues with this label are in the ownership of the unblocking team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Milestone

129th sprint - Core Services team

Development

Successfully merging this pull request may close these issues.

3 participants

@bliuchak @jirimoravcik @tobice