Skip to content

fix: Tailscale steps order - #162

Merged
seyhello merged 1 commit into
mainfrom
fix/tailscalesteporder
Dec 5, 2024
Merged

fix: Tailscale steps order#162
seyhello merged 1 commit into
mainfrom
fix/tailscalesteporder

Conversation

@seyhello

@seyhello seyhello commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Fix:

  • Tailscale steps order changed, they must be behind each other as without it, the IAM Assume role step could fail

@seyhello seyhello added the adhoc Ad-hoc unplanned task added during the sprint. label Dec 5, 2024
@seyhello
seyhello requested a review from fnesveda December 5, 2024 06:35
@seyhello seyhello self-assigned this Dec 5, 2024
@github-actions github-actions Bot added this to the 104th sprint - Platform team milestone Dec 5, 2024
@github-actions github-actions Bot added the t-core-services Issues with this label are in the ownership of the core services team. label Dec 5, 2024
@seyhello
seyhello requested a review from lukasmrtvy December 5, 2024 06:45

@fnesveda fnesveda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small note

Comment on lines +199 to +203
# Bug https://github.com/tailscale/github-action/issues/107
#- name: Tailscale sleep workaround
# run: |
# sleep 10

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be removed now, since we have the next step?

@seyhello
seyhello merged commit b3343e1 into main Dec 5, 2024
@seyhello
seyhello deleted the fix/tailscalesteporder branch December 5, 2024 08:05
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants