Skip to content

feat: Add more inputs and outputs to the commit action to make it more useful#298

Merged
fnesveda merged 4 commits into
mainfrom
feat/add-inputs-to-commit-action
May 15, 2026
Merged

feat: Add more inputs and outputs to the commit action to make it more useful#298
fnesveda merged 4 commits into
mainfrom
feat/add-inputs-to-commit-action

Conversation

@fnesveda
Copy link
Copy Markdown
Member

@fnesveda fnesveda commented May 14, 2026

In https://github.com/apify/store-website-content-crawler/pull/753#discussion_r3240499474, we've decided to add a few inputs and outputs to the shared commit action to enable easier usage of it.

The changes are:

  • added path input specifying which files should be staged before the commit
  • added pull input specifying whether to call git pull before the commit and with what parameters
  • added retries input specifying how many retries to do in case of errors
  • renamed commit-message input to message
  • added committed output saying true / false whether the commit actually happened, or whether there were no changes
  • changed commit-sha output to commit_sha, and it contains the short SHA
  • added commit_long_sha output

They mirror the interface of EndBug/add-and-commit for an easier migration from that action.

@fnesveda fnesveda requested review from B4nan and barjin May 14, 2026 14:31
@fnesveda fnesveda self-assigned this May 14, 2026
@fnesveda fnesveda added the adhoc Ad-hoc unplanned task added during the sprint. label May 14, 2026
@github-actions github-actions Bot added t-management Issues with this label belong to the CTO or engineering managers. tested Temporary label used only programatically for some analytics. labels May 14, 2026
Comment thread commit/action.yml Outdated
@fnesveda fnesveda changed the title feat: Add path and pull inputs, committed output to `commit action feat: Add path and pull inputs, committed output to commit action May 14, 2026
@fnesveda fnesveda requested a review from janbuchar May 14, 2026 16:18
Copy link
Copy Markdown
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fnesveda !

The only point I'd like to discuss deeper is the path / add option naming. The rest are rather optional nits (or documentation).

Cheers!

Comment thread commit/action.yml Outdated
Comment thread commit/action.yml Outdated
Comment thread commit/action.yml Outdated
Comment thread commit/README.md Outdated
@fnesveda fnesveda requested a review from barjin May 15, 2026 10:05
Copy link
Copy Markdown
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @fnesveda !

@fnesveda fnesveda requested a review from vladfrangu May 15, 2026 11:39
@fnesveda fnesveda changed the title feat: Add path and pull inputs, committed output to commit action feat: Add more inputs and outputs to the commit action to make it more useful May 15, 2026
@fnesveda fnesveda merged commit a1e8619 into main May 15, 2026
4 of 6 checks passed
@fnesveda fnesveda deleted the feat/add-inputs-to-commit-action branch May 15, 2026 13:49
MrkMrk00 pushed a commit that referenced this pull request May 21, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.45.0](v0.44.0...v0.45.0)
(2026-05-21)


### Features

* Add more inputs and outputs to the `commit` action to make it more
useful ([#298](#298))
([a1e8619](a1e8619))

* Removes archived Grafana annotation action
#300

### Bug Fixes

* switch packageManager devEngines to warn + add minimumReleaseAge
([#286](#286))
([c0c1014](c0c1014))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-management Issues with this label belong to the CTO or engineering managers. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants