Several fixes for OLink JSON encoding and property behavior#10
Merged
Conversation
If the value of a property is changed using the set method, we automatically notify all listeners about that change.
The alias name was not used by the json.dumps() method and thus used the variable name which is different than the one specified in the IDL. Therefore we now enforce using the alias as it is defined in the IDL.
The new cli version contains the updated default filter for structs. Therefore, we need to update the goldenmaster to reflect these changes.
We need to initialize structs in the default constructor to use proper values during the json serialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
✅ Checks