Skip to content

Dphan/apigear next#24

Merged
dorotaphanSiili merged 10 commits into
mainfrom
dphan/apigear-next
Aug 5, 2024
Merged

Dphan/apigear next#24
dorotaphanSiili merged 10 commits into
mainfrom
dphan/apigear-next

Conversation

@dorotaphanSiili
Copy link
Copy Markdown
Collaborator

@dorotaphanSiili dorotaphanSiili commented Jun 3, 2024

  1. Reorganize the repository:
  • clean up structure
  • partially solve [FEAT]: fix relative import #16 by splitting olink top level files into apigear olink module and examples with context path
  • make a python module of each apigear module - group submodules _api _olink _impl into one folder for each apigear module and loose prefic module_name from directories. The usage then would be module_name.api instead module_name_api
  • solve rest of [FEAT]: fix relative import #16 all generated files can be an import package (add toplevel _ _ init _ _.py and adjust all absolut imports to start with toplevel) and optionally also the distribution package (installable, with pyroject.toml) - ? can something more be done about it? requires discussion. For now a project that uses it adds a path
  1. Implement features for apigear next

Closes # #22 #23
Also closes
#27

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@dorotaphanSiili dorotaphanSiili force-pushed the dphan/apigear-next branch 2 times, most recently from 43a396a to 739a2d1 Compare July 19, 2024 12:45
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a new line at the end of the file not on the first line?

Comment thread goldenmaster/tb_same1/api/api.py Outdated
from pydantic import ConfigDict, BaseModel, Field
from enum import IntEnum


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That empty new line should also not be here.

@dorotaphanSiili dorotaphanSiili force-pushed the dphan/apigear-next branch 2 times, most recently from 2367a40 to 8f0de31 Compare July 20, 2024 08:27
system client and server were split into: an apigear olink package which
contains comon client and server functionality and a examles directory
which uses this functionality along with generated olink adapters.
The examples were given a path context, so all the imports work.
@dorotaphanSiili dorotaphanSiili merged commit f6bcf0a into main Aug 5, 2024
@dorotaphanSiili dorotaphanSiili deleted the dphan/apigear-next branch August 5, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement support for extern types for apigear next Implement imports feature for apigear next

2 participants