Skip to content

fix: include (not set) proxy type calls in standard and total counts (#714)#725

Open
saiflayouni wants to merge 1 commit into
apigee:mainfrom
saiflayouni:fix/reports-not-set-proxy-type
Open

fix: include (not set) proxy type calls in standard and total counts (#714)#725
saiflayouni wants to merge 1 commit into
apigee:mainfrom
saiflayouni:fix/reports-not-set-proxy-type

Conversation

@saiflayouni

Copy link
Copy Markdown

Summary

  • When proxy_deployment_type dimension returns (not set) values, those API calls were added to totalApiCalls but silently dropped from totalStandard, making them invisible in the --proxy-type billing report output
  • EXTENSIBLE and STANDARD dimension calls also did not contribute to totalApiCalls, so the total count only reflected unclassified proxies when dimension mode was active
  • Fixed by accumulating all dimension values (EXTENSIBLE, STANDARD, (not set)) into totalApiCalls, and also crediting (not set) calls to totalStandard (unclassified proxies are not extensible and should count as standard)

Fixes #714

Test plan

  • Run apigeecli reports total-api-calls --proxy-type against an environment that has proxies with mixed or missing deployment types
  • Verify the standard count now includes calls from proxies with (not set) deployment type
  • Verify the total count matches extensible + standard

🤖 Generated with Claude Code

@google-cla

google-cla Bot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

When proxy_deployment_type is (not set), calls were added to totalApiCalls
but not to totalStandard, making them invisible in --proxy-type billing reports.
Also ensures EXTENSIBLE and STANDARD calls contribute to totalApiCalls so the
total count is accurate across all deployment types.

Fixes apigee#714
@saiflayouni saiflayouni force-pushed the fix/reports-not-set-proxy-type branch from 4b84ac7 to b1f9fee Compare July 1, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] organizations reports returning only some data (or none)

1 participant