fix: include (not set) proxy type calls in standard and total counts (#714)#725
Open
saiflayouni wants to merge 1 commit into
Open
fix: include (not set) proxy type calls in standard and total counts (#714)#725saiflayouni wants to merge 1 commit into
saiflayouni wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
When proxy_deployment_type is (not set), calls were added to totalApiCalls but not to totalStandard, making them invisible in --proxy-type billing reports. Also ensures EXTENSIBLE and STANDARD calls contribute to totalApiCalls so the total count is accurate across all deployment types. Fixes apigee#714
4b84ac7 to
b1f9fee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxy_deployment_typedimension returns(not set)values, those API calls were added tototalApiCallsbut silently dropped fromtotalStandard, making them invisible in the--proxy-typebilling report outputEXTENSIBLEandSTANDARDdimension calls also did not contribute tototalApiCalls, so the total count only reflected unclassified proxies when dimension mode was activeEXTENSIBLE,STANDARD,(not set)) intototalApiCalls, and also crediting(not set)calls tototalStandard(unclassified proxies are not extensible and should count as standard)Fixes #714
Test plan
apigeecli reports total-api-calls --proxy-typeagainst an environment that has proxies with mixed or missing deployment types(not set)deployment type🤖 Generated with Claude Code