add debug statements for oauth#5
Conversation
|
basic plugin for healthcheck |
healthcheck/package.json
Outdated
| "url": "git+https://github.com/apigee/microgateway-plugins.git" | ||
| }, | ||
| "author": "srinandan", | ||
| "license": "ISC", |
There was a problem hiding this comment.
Can you change this to Apache 2?
|
done |
| var disable = false; | ||
|
|
||
| //method to accumulate responses | ||
| function accumulateResponse(res, data) { |
There was a problem hiding this comment.
Should this be here? Or should this plugin be used in conjunction with the accumulate plugins?
There was a problem hiding this comment.
The accumulate plugin does not store the content anywhere so it can be accessed by a subsequent plugin. I'm ok if we were to change the accumulate plugin's behaviour and remove this code from here.
There was a problem hiding this comment.
It doesn't pass the full body as the data argument?
There was a problem hiding this comment.
No, accumulate passes a chunk (when the size is small, it could be the full body).
| } | ||
|
|
||
| //method to accumulate requests | ||
| function accumulateRequest(req, data) { |
There was a problem hiding this comment.
Should this be here? Or should this plugin be used in conjunction with the accumulate plugins?
3 participants
No description provided.