Skip to content

fix: pass package settings directory only when package settings applied #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliasghar98 merged 3 commits into from
Apr 28, 2026
Merged

fix: pass package settings directory only when package settings applied #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d420a28
fix: pass package settings directory only when package settings applied
aliasghar98 Apr 28, 2026
4b4a64c
refactor: pass packageSettingsDirectory properly instead of temp dire…
aliasghar98 Apr 28, 2026
d7f4bd9
fix: update env info to correctly pick url
aliasghar98 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/actions/sdk/publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ export class SdkPublishAction {
): Promise<ActionResult<PublishingInfo>> => {
return await withDirPath(async (tempDirectory) => {
const packageConfiguration = publishingProfile.getPackageConfigurationForLanguage(language);
let packageSettingsDirectory: DirectoryPath | undefined;

if (packageConfiguration !== null && packageConfiguration.isEnabled) {
const packageSettingsConfiguration = PackageSettingsConfiguration.create(language, packageConfiguration);
const packageSettingsDirectory = tempDirectory.join('package-settings');
packageSettingsDirectory = tempDirectory.join('package-settings');
const packageSettingsContext = new PackageSettingsContext(packageSettingsDirectory);
await packageSettingsContext.writeConfiguration(packageSettingsConfiguration, language);
}
Expand All @@ -57,7 +59,7 @@ export class SdkPublishAction {
false,
undefined,
semVersion,
tempDirectory
packageSettingsDirectory
);
if (sdkGenerationResult.isFailed()) {
return ActionResult.failed();
Expand Down
2 changes: 1 addition & 1 deletion src/infrastructure/env-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class EnvInfo {
const envBaseUrls = process.env.APIMATIC_BASE_URL;
if (envBaseUrls) {
const baseUrls = envBaseUrls.split(';');
EnvInfo.cachedAuthBaseUrl = baseUrls.length === 2 ? baseUrls[1] : undefined;
EnvInfo.cachedAuthBaseUrl = baseUrls.length === 3 ? baseUrls[1] : undefined;
}
return EnvInfo.cachedAuthBaseUrl;
}
Expand Down
2 changes: 1 addition & 1 deletion src/types/build-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class BuildContext {
const tempBuildDir = tempDir.join("build");
await this.fileService.copyDirectoryContents(this.buildDirectory, tempBuildDir);
if (packageSettingsDirectory) {
await this.fileService.copyDirectoryContents(packageSettingsDirectory.join('package-settings'), tempBuildDir.join('package-settings'));
await this.fileService.copyDirectoryContents(packageSettingsDirectory, tempBuildDir.join('package-settings'));
}
return await tempContext.zip(tempBuildDir);
}
Expand Down