Skip to content

ci(test-lts-java-versions): test suite for Java 11, 17 & 19 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asadali214 merged 5 commits into from
Mar 28, 2023
Merged

ci(test-lts-java-versions): test suite for Java 11, 17 & 19 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b03ca5a
ci(test-lts-java-versions): test suite for Java 11, 17 & 19
asadali214 Mar 28, 2023
c9cf07a
fixed incorrect doc blocks in TestHelper
asadali214 Mar 28, 2023
f0122ff
fix wrong indentation
asadali214 Mar 28, 2023
7059aee
Added configuration source of javadoc to jdk version 8
asadali214 Mar 28, 2023
d641359
Merge branch '62-ci-test-lts-java' of https://github.com/apimatic/cor…
asadali214 Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,20 @@ on:
branches:
- main
pull_request:

jobs:
build-and-test:
name: Test using Java ${{ matrix.java }}
runs-on: ubuntu-latest

strategy:
matrix:
java: [ '8', '11', '17', '19' ]
steps:
- uses: actions/checkout@v3
- name: Set up JDK 8
- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v3
with:
java-version: '8'
java-version: ${{ matrix.java }}
distribution: 'temurin'
cache: maven
- name: Build with Maven
Expand Down
3 changes: 3 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>2.9.1</version>
<configuration>
<source>8</source>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/io/apimatic/core/utilities/TestHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ private static boolean isProperSubsetOf(
* @param allowExtra extra value is allowed?.
* @param isOrdered object value is in order?.
* @throws IOException Signal that I/O errors occur.
* @return <tt>true</tt> if left left JSON object is a proper subset of right JSON object.
* @return true if left left JSON object is a proper subset of right JSON object.
*/
public static boolean isJsonObjectProperSubsetOf(
String leftObject, String rightObject, boolean checkValues, boolean allowExtra,
Expand Down Expand Up @@ -441,7 +441,7 @@ private static boolean isListProperSubsetOf(
* @param leftTree Left headers map.
* @param rightTree Right headers map.
* @param checkValues Check header values for equality?.
* @return <tt>true</tt> if left headers map is a proper subset of right headers map.
* @return true if left headers map is a proper subset of right headers map.
*/
public static boolean areHeadersProperSubsetOf(
Map<String, String> leftTree, Map<String, String> rightTree, boolean checkValues) {
Expand Down