Conversation
There was a problem hiding this comment.
PR Review: apimatic-sdk skill
The skill is well-architected overall — strong eval suite (41 cases), clean progressive disclosure, and the 14-item red flags section is the best part of the SKILL.md. Two blocking issues need resolution before merge.
Blocking:
- B1. Missing
scripts/auth-login.mjs— runtime failure on first use (see inline comment) - B2.
--track-changescontradicts between SKILL.md and the example file (see inline comments)
Suggestion:
- I3. Add a publishing example file to
examples/(see inline comment)
Details inline below.
Additionally, in terms of the structure of SKILLs.md, it might make sense to have 3 sections:
- Generate an SDK
- Customize an SDK
- Publish an SDK
The last 2 are covered, but the first isn't explicitly mentioned, although it is implied in both of the sections.
Do you think we need to have a separate SDK generation section ?
|
|
||
| Ask: "Do you already have a generated SDK you've customized, or are you starting fresh?" | ||
| - **Already has a customized SDK →** Skip generation entirely. Ask: "Would you like me to apply the customizations, or will you handle them yourself?" then follow the appropriate path below. | ||
| - **Starting fresh →** Add the `--track-changes` flag to the generate command. After generation completes in Step 7, ask: "Would you like me to apply the customizations, or will you handle them yourself?" then follow the appropriate path below. |
There was a problem hiding this comment.
B2. --track-changes contradicts between SKILL.md and the example file
SKILL.md says here to "Add the --track-changes flag to the generate command" and the Additional flags section (line 342) says it "Must be used during the initial generation to set up the source tree."
But examples/generate-customize-save.md says "Change tracking is enabled automatically" and its generate command omits --track-changes:
apimatic sdk generate --language=typescript
Evals 6, 10, and 11 all assert --track-changes must be present, aligning with SKILL.md.
The agent receives contradictory instructions. One of these artifacts is teaching wrong behavior.
Suggested fix — determine which is correct:
- If
--track-changesis required: update the example to include the flag and remove the "enabled automatically" line - If tracking is now automatic in the CLI: update SKILL.md and evals 6, 10, 11 to reflect this
There was a problem hiding this comment.
--track-changes flag is required to enable tracking, I have updated the example.
Reagrding the last point, the generation steps were already there, I've grouped them under a |
Adds a new skill for generating, customizing, and managing SDKs using the APIMatic CLI.
What's included: