Skip to content

Conversation

@deligence-dharmendra
Copy link
Contributor

Closes #3300

Changes

  • changes in API card HTML, add a link in API logo

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @matleppa @marla-singer

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost added the in progress label Jan 10, 2018
@marla-singer
Copy link
Contributor

@deligence-dharmendra Make a logo as a link with Table view as well.

@marla-singer marla-singer self-assigned this Jan 10, 2018
@deligence-dharmendra
Copy link
Contributor Author

@marla-singer OK

@marla-singer marla-singer added this to the Sprint 62 milestone Jan 10, 2018
@marla-singer marla-singer merged commit 8e3344c into develop Jan 10, 2018
@ghost ghost removed the Ready for review label Jan 10, 2018
@marla-singer marla-singer deleted the feature/api-card-logo-in-apis-listing-as-link-to-api-profile branch January 10, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants