Skip to content

When importing API with open API specification, skip the desription if it is too long #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marla-singer merged 4 commits into from
Jan 17, 2018
Merged

When importing API with open API specification, skip the desription if it is too long #3324

marla-singer merged 4 commits into from
Jan 17, 2018

Conversation

@saransh-dev
Copy link
Contributor

@saransh-dev saransh-dev commented Jan 13, 2018 •
edited by marla-singer
Loading

…escription

Closes #3305
Closes #3332

Changes

  • make condition for description length.

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @marla-singer

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned saransh-dev Jan 13, 2018
@ghost ghost added the in progress label Jan 13, 2018
marla-singer
marla-singer suggested changes Jan 15, 2018
View reviewed changes
apinf_packages/apis/server/methods/config.js Outdated
// Use provided schema
urlSchema = result.schemes[0];
}
const description = result.info.description.length <= 1000 ?
Copy link
Contributor

@marla-singer marla-singer Jan 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be case when result.info.description is undefined and it will throw error.

hadle this cases

@ghost ghost added the in progress label Jan 16, 2018
@saransh-dev saransh-dev mentioned this pull request Jan 16, 2018
Closed
@marla-singer marla-singer added this to the Sprint 62 milestone Jan 17, 2018
marla-singer
marla-singer approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@marla-singer marla-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good

@marla-singer marla-singer merged commit f9d13ff into develop Jan 17, 2018
@ghost ghost removed the in progress label Jan 17, 2018
@marla-singer marla-singer deleted the bugfix/import-api-with-open-api-specification-skip-description branch January 17, 2018 12:12
@marla-singer marla-singer changed the title working on When importing API with open API specification, skip the d… When importing API with open API specification, skip the desription if it is too long Jan 17, 2018
@Nazarah Nazarah mentioned this pull request Feb 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marla-singer marla-singer marla-singer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saransh-dev saransh-dev

Labels

None yet

Projects

None yet

Milestone

Sprint 62

Development

Successfully merging this pull request may close these issues.

2 participants

@saransh-dev @marla-singer