Skip to content

Conversation

@deligence-dharmendra
Copy link
Contributor

Closes #3340

Changes

  • change in manage.html file
  • class changes in the list.html file

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @marla-singer @matleppa

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality as expected.

@matleppa matleppa merged commit afeed4a into develop Jan 23, 2018
@ghost ghost removed the Ready for review label Jan 23, 2018
@marla-singer marla-singer deleted the bugfix/ui-unify-delete-buttons-within-lists branch January 25, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants