Skip to content

Keep error messages visible until the user closes them #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matleppa merged 2 commits into from
Jan 31, 2018
Merged

Keep error messages visible until the user closes them #3363

matleppa merged 2 commits into from
Jan 31, 2018

Conversation

@deligence-dharmendra
Copy link
Contributor

@deligence-dharmendra deligence-dharmendra commented Jan 30, 2018 •
edited
Loading

Closes #3347

Changes

  • changes in s-alert error params

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @matleppa @marla-singer

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost added the in progress label Jan 30, 2018
@marla-singer marla-singer self-assigned this Jan 31, 2018
@matleppa matleppa changed the title Feature/keep error visible until the user closes those Keep error messages visible until the user closes them Jan 31, 2018
matleppa
matleppa approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality as expected.

@matleppa matleppa merged commit c92aad4 into develop Jan 31, 2018
@ghost ghost removed the in progress label Jan 31, 2018
@matleppa matleppa deleted the feature/keep-error-visible-until-the-user-closes-those branch January 31, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matleppa matleppa matleppa approved these changes

@marla-singer marla-singer Awaiting requested review from marla-singer

Assignees

@marla-singer marla-singer

@deligence-dharmendra deligence-dharmendra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deligence-dharmendra @matleppa @marla-singer