Skip to content

Cleared up erroneous code in Gate_1 #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
preriasusi merged 1 commit into from
Jul 5, 2018
Merged

Cleared up erroneous code in Gate_1 #3495

preriasusi merged 1 commit into from
Jul 5, 2018

Conversation

@Nazarah
Copy link
Contributor

@Nazarah Nazarah commented May 31, 2018

Closes #3494

Changes

  • 5.proxy.robot: added sleeping time so that the whole page is loaded before Proxy tab is clicked in API profile.
  • 6.profile.robot: cleared up codes (mistakenly added assuming comments) that was causing the test case to fail individually or as a collection.
  • In 6.profile.robot test suite, Login to APInf testcase has been modified so that function receives argument properly
    Login to apinf asdas asdasd
  • In 6.profile.robot test suite, Login to APInf testcase now waits for the sign-out button to appear on footer. This ensures user has logged in.
    Wait Until Page Contains Element id=at-btn
  • In 6.profile.robot test suite, Go to login keyword has now new codes to identify if an element is present in the page
    Wait Until Page Contains Element id=statisticswrap
    Wait Until Page Contains Element id=at-btn
  • In 6.profile.robot test suit, the keywords have been organized.

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

Cleared up erroneous code in Gate_1
a950586 
1. 5.proxy.robot - added sleeping time  so that the whole page is loaded before Proxy tab is clicked in API profile.

2. 6.profile.robot cleared up codes (mistakenly added assuming comments) that was causing the test case to fail individually or as a collection.

3. In 6.profile.robot test suite, Login to APInf testcase has been modified so that function receives argument properly

"Login to apinf  asdas  asdasd"

4. In 6.profile.robot test suite, Login to APInf testcase now waits for the sign-out button to appear on footer. This ensures user has logged in.

"Wait Until Page Contains Element  id=at-btn"

5. In 6.profile.robot test suite, Go to login keyword has now  new codes to identify if an element is present in the page

"Wait Until Page Contains Element  id=statisticswrap"

"Wait Until Page Contains Element  id=at-btn"

6. In 6.profile.robot test suit, the keywords have been organized.
@ghost ghost assigned Nazarah May 31, 2018
@ghost ghost added the in progress label May 31, 2018
@Nazarah Nazarah requested a review from marla-singer May 31, 2018 10:33
@Nazarah Nazarah removed the request for review from marla-singer May 31, 2018 10:33
@Nazarah Nazarah requested a review from marla-singer May 31, 2018 10:42
@preriasusi preriasusi requested review from preriasusi and removed request for marla-singer June 27, 2018 11:03
@preriasusi preriasusi merged commit 203ad27 into develop Jul 5, 2018
@ghost ghost removed the Ready for review label Jul 5, 2018
@phanimahesh phanimahesh deleted the bugfix/robot-testcases branch October 31, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@preriasusi preriasusi preriasusi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Nazarah Nazarah

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nazarah @preriasusi