Show server timezone in Dashboard & API Analytics #3501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. created "getServerTimeZone" function in store.js to retrieve server time and extract the time zone. 2. Added new label "apiAnalyticPageHeader_helpText_serverTimezone" in en.i18n.json to show server timezone in API analytics page header. 3. Added new label "dashboardOverviewStatistic_helpText_serverTimezone" in en.i18n.json to show server timezone on each row in Dashboard. 4. Added new template "'apiAnalyticPageHeader_helpText_serverTimezone' servertimezone=(serverTimeZone)" in header.html to show server timezone as help text on API analytics page header. 5. In header.js, created new function calling server to retreive server timezone. Also created associated helper function "serverTimeZone()" to display the timezone in API analytics page header. 6. Added new template "'dashboardOverviewStatistic_helpText_serverTimezone' servertimezone=(serverTimeZone)" in overview.html to show server timezone as help text on each row in Dashboard. 7. In overview.js, created new function calling server to retreive server timezone. Also created associated helper function "serverTimeZone()" to display the timezone on each row in Dashboard.
ghost
assigned
1. header.js: added space between comment symbol and text
2. header.js: added space "," in Meteor.call('getServerTimeZone', (error, result) =>
3. overview.js: imported Meteor and ReactiveVar packages.
Contributor
Author
|
Also Under fac5cc4 commit, in store.js. redefined the variables serverTime and timeZone as "const" to fix travis build errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1878
Closes #1886
Changes
created getServerTimeZone function in store.js to retrieve server time and extract the time zone.
Added new label apiAnalyticPageHeader_helpText_serverTimezone in en.i18n.json to show server timezone in API analytics page header.
Added new label dashboardOverviewStatistic_helpText_serverTimezone in en.i18n.json to show server timezone on each row in Dashboard.
Added new template
'apiAnalyticPageHeader_helpText_serverTimezone' servertimezone=(serverTimeZone)in header.html to show server timezone as help text on API analytics page header.In header.js, created new function calling server to retrieve server timezone. Also created associated helper function
serverTimeZone()to display the timezone in API analytics page header.Added new template
'dashboardOverviewStatistic_helpText_serverTimezone' servertimezone=(serverTimeZone)in overview.html to show server timezone as help text on each row in Dashboard.In overview.js, created new function calling server to retrieve server timezone. Also created associated helper function
serverTimeZone()to display the timezone on each row in Dashboard.Developer checklist
This checklist is to be completed by the PR developer:
Reviewer checklist
Reviewed by: @username1
This list is to be completed by the pull request reviewer: