Skip to content

Improve 3rd party authorization login parameter update #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilarimikkonen merged 18 commits into from
Oct 22, 2018
Merged

Improve 3rd party authorization login parameter update #3587

ilarimikkonen merged 18 commits into from
Oct 22, 2018

Conversation

@matleppa
Copy link
Member

@matleppa matleppa commented Oct 12, 2018

Closes #3586

Changes

  • ability to reset login parameter given by 3rd party input UI using login platform UI
  • parameter values in login platform UI are updated to same level as given via 3rd party UI

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

matleppa and others added 16 commits September 21, 2018 15:52
@matleppa
Added OIDC login functionality
f1f0353 
- new login button
- better interworking with LoginPlatforms and ServiceConfiguration
- ability to also remove login settings via Login platforms page
- parameter values from ServiceConfiguration to LoginPlatforms are updated, when Login platforms page is created
@matleppa
Added social icons for fiware and oidc
016d1aa
@matleppa
Added updating service configuration values to loginPlatform
e273038
@matleppa
Updated oidc fields in loginPlatform
da4bd6e
@matleppa
Possibility to update tokenWhiteList in loginPlatform
2d4ecad
@matleppa
lint fix
a3e5bd9
@matleppa
package for OIDC
561b2ef
@matleppa
Added OAuth functionality for HSL
870ece3 
Very strongly inspired by Salleman package.
@matleppa
Added package Oauth2
c8bb234
@matleppa
Removed unnecassary package Oauth2
5e42263
@matleppa
Removed not necessary import of HTTP
2ffa8f3
@matleppa
Changes in social icons
e9bd4b5 
- removed fa-rockets
- added HSL logo as a background image
@ilarimikkonen
update due to build failure
ba7dc47 
error limax@1.7.0: The engine "node" is incompatible with this module. Expected version ">=6".
@matleppa
Lint fixes
fb5d1ce
@matleppa
Merge branch 'feature/select-signin-mechanism-mfa' of https://github.…
dd16e92 
…com/apinf/platform into feature/select-signin-mechanism-mfa
@matleppa
Included only login parameter handling
c44f419
@ghost ghost assigned matleppa Oct 12, 2018
@ghost ghost added the in progress label Oct 12, 2018
ilarimikkonen
ilarimikkonen approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@ilarimikkonen ilarimikkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ilarimikkonen ilarimikkonen merged commit b6f304f into develop Oct 22, 2018
@ghost ghost removed the Ready for review label Oct 22, 2018
@phanimahesh phanimahesh deleted the feature/improve-login-parameter-update branch October 31, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilarimikkonen ilarimikkonen ilarimikkonen approved these changes

Assignees

@matleppa matleppa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matleppa @ilarimikkonen