Skip to content

Conversation

@matleppa
Copy link
Member

@matleppa matleppa commented Nov 5, 2018

Closes #3593 (as a side effect)

Changes

  • New OAuth login button (HSL)
  • login is accepted via HSL OAuth

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned matleppa Nov 5, 2018
@ghost ghost added the in progress label Nov 5, 2018
Functionality will be implemented later, after Next
Navbar sisplay method was changed  to be dynamic in MQTT implementation.
Call for navbar was missing in case signIn and signUp.
Also indicate, which parameters are updated
Copy link
Member

@ilarimikkonen ilarimikkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@ilarimikkonen ilarimikkonen merged commit c7ca94b into develop Nov 8, 2018
@ghost ghost removed the Ready for review label Nov 8, 2018
@ilarimikkonen ilarimikkonen deleted the feature/hsl-oidc-2 branch November 30, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants