Fixed reshape function and booleans handling#57
Merged
Conversation
Reshape was implemented on top of a transposition function that was working only for 2D matrix. The new implementation works by computing the new index of each element for the new reshaped array. This implementation is more likely to work as the python numpy reshape method
Added tests for the boolean handling Fixed some types that were failing on `tsc`
Member
|
Amazing!!! This is so great!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the reshape function to work with fortran order and multi dimensional matrix
Boolean type handling in load and dump functions
Fixed some types failing on
tsc