Conversation
malinink
requested changes
Mar 13, 2019
Domain/basicModelInterfaces.go
Outdated
| GetNumber() int | ||
| } | ||
|
|
||
| type JobsModelInterface interface { |
Domain/repositoriesInterface.go
Outdated
| @@ -1,4 +1,7 @@ | |||
| package Domain | |||
|
|
|||
| type RepositoryInterface interface { | |||
Contributor
There was a problem hiding this comment.
ClientRepositoryInterface ? It's just an idea, we could refactor when there is need to add one more repo into project
Domain/repositoriesInterface.go
Outdated
| package Domain | ||
|
|
||
| type RepositoryInterface interface { | ||
| GetUser(id int) UserApplicationModelInterface |
Domain/viewModelInterface.go
Outdated
| package Domain | ||
|
|
||
| type HelloWorldViewModel interface { | ||
| type UserViewModelInterface interface { |
Contributor
There was a problem hiding this comment.
Also Client ?
P.S. Is it a good idea to call "Client" all Bank clients?
Cause of user - could be any user, i.e. not a client.
malinink
approved these changes
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4