container: introduce per-instance default options

[srijs]

In order to be able to set default options for common operations on a container,
introduce a default options object per operation that can be overwritten from the outside.

Together with #60 this resolves #57, because you can now do:

docker.run(..., function (...) {
  ...
}).on('container', function (container) {
  container.defaultOptions.start.Binds = ["/tmp:/tmp:rw"];
});

[apocas]

I like this pattern/combo.

But I think I see a problem, imagine that someone wants to define a defaultOption for "attach" instead of "start". This may asynchronous fail. (with "start" it will probably work, since "attach" is done first giving it time)

https://github.com/apocas/dockerode/blob/master/lib/docker.js#L258

[srijs]

There'll be no problem with that, because semantically all event handlers for the container event will be processed before continuing to the attach call. (see this for reference)

[apocas]

👍
I always avoided patterns like these thinking that way, just read a bit it will work indeed.

Want do drop that run->start example into readme.md?
Think this combo will be helpful for a lot of people using "run" :)

We should deprecate the current "options" parameter from run, since it doesn't give complete functionality and this pattern is way superior.

[apocas]

Will add the example myself, since I'm prepping the next release right now and really wanna to have this in :)

[srijs]

Are you talking about the options parameter on docker.run? It's the only way to pass parameters for creating a container right now. So you shouldn't deprecate that.

[apocas]

Duh you are right. Will express this clearly in the documentation.

[apocas]

Published v1.3.0