Skip to content

[Merged] MagicOnMob VerificationHandler#426

Closed
Tomm0017 wants to merge 3 commits into
apollo-rsps:kotlin-experimentsfrom
Tomm0017:magic_on_mob
Closed

[Merged] MagicOnMob VerificationHandler#426
Tomm0017 wants to merge 3 commits into
apollo-rsps:kotlin-experimentsfrom
Tomm0017:magic_on_mob

Conversation

@Tomm0017
Copy link
Copy Markdown

@Tomm0017 Tomm0017 commented Apr 26, 2019

Addresses Issue #335 where a VerificationHandler for MagicOnMobMessage is requested. Verifies the following conditions:

The Mob exists (i.e. index is valid)
Type of the Mob matches the Mob at the index
The Mob is within distance of the player

The verification for combat related conditions are left for plugins to handle.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #426 into kotlin-experiments will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             kotlin-experiments     #426      +/-   ##
========================================================
- Coverage                 23.23%   23.19%   -0.04%     
  Complexity                  811      811              
========================================================
  Files                       643      644       +1     
  Lines                     11123    11139      +16     
  Branches                   1632     1636       +4     
========================================================
  Hits                       2584     2584              
- Misses                     8251     8267      +16     
  Partials                    288      288
Impacted Files Coverage Δ Complexity Δ
...message/handler/MagicOnMobVerificationHandler.java 0% <0%> (ø) 0 <0> (?)
...rg/apollo/game/message/impl/MagicOnMobMessage.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd06a69...5d83a8f. Read the comment docs.

Major- added a commit that referenced this pull request Jul 13, 2019
@Major-
Copy link
Copy Markdown
Member

Major- commented Jul 13, 2019

Merged in 1b3f1ab.

@Major- Major- closed this Jul 13, 2019
@Major- Major- changed the title MagicOnMob VerificationHandler [Merged] MagicOnMob VerificationHandler Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants