fix: Bump h2database and snakeyaml version#5406
fix: Bump h2database and snakeyaml version#5406hezhangjian merged 1 commit intoapolloconfig:masterfrom
Conversation
* build(deps): bump com.h2database:h2 from 2.1.214 to 2.2.220 * build(deps): bump org.yaml:snakeyaml from 1.3.4 to 2.3
WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ItemController
participant SnakeYAML
User->>ItemController: Request to process YAML
ItemController->>SnakeYAML: Instantiate Yaml with LoaderOptions and DumperOptions
SnakeYAML-->>ItemController: Yaml instance (with secure configuration)
ItemController-->>User: Processed YAML response
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGES.md (1)
17-17: Use consistent release note labels for security fixes.
Other security-related entries use the[Security: ...]tag. Consider renaming this line for consistency:-* [Fix: Bump h2database and snakeyaml version](https://github.com/apolloconfig/apollo/pull/5406) +* [Security: Bump h2database and snakeyaml version](https://github.com/apolloconfig/apollo/pull/5406)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGES.md(1 hunks)apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ItemController.java(1 hunks)pom.xml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (8)
🔇 Additional comments (3)
pom.xml (2)
79-81: Properties version bump aligned with CVE fixes.
Addedh2database.versionandsnakeyaml.versionto centralize the updated, secure versions addressing CVE-2022-45868 and CVE-2022-1471.
205-216: Manage H2 and SnakeYAML versions in dependencyManagement.
The new entries forcom.h2database:h2:${h2database.version}andorg.yaml:snakeyaml:${snakeyaml.version}correctly enforce the bumped versions across all modules without altering runtime dependencies at the parent POM level.apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ItemController.java (1)
270-273: Explicit YAML configuration with SafeConstructor and DumperOptions.
InstantiatingDumperOptionsand passing bothloaderOptionsanddumperOptionsinto theYamlconstructor ensures duplicate keys are disallowed and dumping behavior is controlled under SnakeYAML v2.3’s API.
What's the purpose of this PR
Fixes CVE-2022-45868
Fixes CVE-2022-1471
Brief changelog
Resolves issue #5386
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit