fix: upgrade vulnerable transitive dependencies (nimbus-jose-jwt, woodstox, jettison)#5543
Conversation
Upgrade transitive dependency versions managed in the root POM to fix known CVEs reported in apollo-common and apollo-biz: - nimbus-jose-jwt: 9.21 → 9.37.3 (fixes CVE-2023-52428) - woodstox-core: 6.2.1 → 6.5.1 (fixes CVE-2022-40152) - jettison: 1.4.0 → 1.5.4 (fixes CVE-2022-40149, CVE-2022-45685, CVE-2022-45693, CVE-2023-1436) Note: H2 (2.2.220), SnakeYAML (2.3), and PostgreSQL JDBC (42.7.2) were already upgraded in previous commits. Spring Boot/Framework/Security major version upgrades (2.x → 3.x) and commons-jxpath (unmaintained) are out of scope for this PR. Ref apolloconfig#5386
📝 WalkthroughWalkthroughAdded three Maven properties and pinned explicit dependencies in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pom.xml`:
- Around line 88-91: Update the override properties to the latest patch versions
for full CVE coverage: change the nimbus-jose-jwt.version property to 10.7 and
the woodstox-core.version property to 7.1.1 (keep jettison.version as-is at
1.5.4); retain the existing properties + <dependencyManagement> override
approach so these updated property values propagate to transitive dependencies
and rebuild to verify no conflicts.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Addresses CodeRabbit review feedback: 9.37.3 still has CVE-2025-53864 (DoS via deeply nested JSON). 9.37.4 is the backport fix for 9.x branch. woodstox-core kept at 6.5.1 — upgrading to 7.x is a major version jump that risks compatibility issues and is out of scope for this PR.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pom.xml`:
- Around line 88-91: Update the overridden nimbus-jose-jwt.version property to
the 9.x branch that contains the CVE-2023-52428 backport (recommended 9.37.4)
instead of 10.7 to maintain compatibility with Spring Security 5.7.x; change the
nimbus-jose-jwt.version property, then run mvn dependency:tree and the full test
suite and specifically exercise OAuth2 flows (spring-boot-starter-oauth2-client
and spring-boot-starter-oauth2-resource-server) to ensure no
ClassCastException/NoSuchMethodError or runtime issues before merging —
alternatively, if you choose to keep 10.7, document that you ran those
dependency and integration tests and they all passed.
…mpatibility - Keeps woodstox-core at 7.1.1 (latest patch) - nimbus-jose-jwt 9.37.4 includes CVE-2023-52428 backport - Maintains compatibility with Spring Boot 2.7.11 (Spring Security 5.7.x)
What's the purpose of this PR
Upgrade transitive dependency versions to fix known CVEs reported in #5386.
升级传递依赖版本,修复 #5386 中报告的已知 CVE。
Ref #5386
Changes / 改动
Override transitive dependency versions via
<dependencyManagement>in the root POM:通过根 POM 的
<dependencyManagement>覆盖传递依赖版本:nimbus-jose-jwtwoodstox-corejettisonAlready fixed in master / 已在 master 修复
The following dependencies mentioned in #5386 have already been upgraded:
以下 #5386 中提到的依赖已在之前的提交中升级:
Out of scope / 不在本 PR 范围
Which issue(s) this PR fixes
Ref #5386
Summary by CodeRabbit