V1 selectionset equality merged fragment child fix #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry picking and resolving merge conflicts to add this feature from v2 back into v1. v2 commit cherry picked: d67339b
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: b6d1f724859fec7394f56a8f |
BobaFetters
approved these changes
Nov 5, 2025
Member
BobaFetters
left a comment
BobaFetters
left a comment
There was a problem hiding this comment.
Think this looks good will defer to @calvincestari since im less familiar with this work
calvincestari
approved these changes
Nov 5, 2025
Member
calvincestari
left a comment
calvincestari
left a comment
There was a problem hiding this comment.
Codegen changes look good. Nice extra test matcher added too.
Contributor
Author
|
Let me take a look at the failing tests here.
I added that in v2 a while ago, just ported it over to v1 now with some of the tests I carried over. |
calvincestari
deleted the
v1-selectionset-equality-merged-fragment-child-fix
branch
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Nov 5, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Nov 5, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
bf71e9c73 V1 selectionset equality merged fragment child fix (#833) 59319e8ab Merge branch 'v1' of https://github.com/apollographql/apollo-ios-dev into v1 4a0f032a8 Release 1.25.2 (#809) git-subtree-dir: apollo-ios git-subtree-split: bf71e9c7373f68b9f5b8d1b9cdf810ebb4e0bf68
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
…t child fix git-subtree-dir: apollo-ios git-subtree-mainline: 2ca1856 git-subtree-split: bf71e9c7373f68b9f5b8d1b9cdf810ebb4e0bf68
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
918b26b96 V1 selectionset equality merged fragment child fix (#833) 29187ab86 Merge branch 'v1' of https://github.com/apollographql/apollo-ios-dev into v1 b40df116e Release 1.25.2 (#809) git-subtree-dir: apollo-ios-codegen git-subtree-split: 918b26b9623e6dc4aebf927b5369fd0f4bc954c7
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
… fragment child fix git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 7d11380 git-subtree-split: 918b26b9623e6dc4aebf927b5369fd0f4bc954c7
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
…ged fragment child fix git-subtree-dir: apollo-ios-pagination git-subtree-mainline: c8f4769 git-subtree-split: 8329416924a384b04b1d7af5ad1db4252121e088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the fix in PR #832 to Apollo iOS 1.0