Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

Remove highlight line comments when copying to clipboard#192

Merged
jgarrow merged 3 commits intomainfrom
jg/remove-highlight-comments-clipboard
Aug 19, 2022
Merged

Remove highlight line comments when copying to clipboard#192
jgarrow merged 3 commits intomainfrom
jg/remove-highlight-comments-clipboard

Conversation

@jgarrow
Copy link
Contributor

@jgarrow jgarrow commented Aug 19, 2022

This PR runs the code string through a .replace to remove all of the // highlight-line, // highlight-start, and // highlight-end comments when clicking the copy to clipboard button.

e.g.

    const {ApolloServer, gql} = require('apollo-server');
    const {readFileSync} = require('fs');
    const {buildSubgraphSchema} = require('@apollo/subgraph'); // highlight-line

when copied should only output:

    const {ApolloServer, gql} = require('apollo-server');
    const {readFileSync} = require('fs');
    const {buildSubgraphSchema} = require('@apollo/subgraph');

TODO

  • Cut new release of chakra-helpers package once changes are approved

@jgarrow jgarrow requested a review from StephenBarlow as a code owner August 19, 2022 15:18
@jgarrow jgarrow requested review from trevorblades and removed request for StephenBarlow August 19, 2022 15:18
@netlify
Copy link

netlify bot commented Aug 19, 2022

Deploy Preview for apollo-monodocs ready!

Name Link
🔨 Latest commit 842b511
🔍 Latest deploy log https://app.netlify.com/sites/apollo-monodocs/deploys/62ffb9a50ead7900084660ca
😎 Deploy Preview https://deploy-preview-192--apollo-monodocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jgarrow jgarrow requested a review from BlenderDude August 19, 2022 15:18
@jgarrow jgarrow requested a review from BlenderDude August 19, 2022 16:23
Copy link
Member

@BlenderDude BlenderDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jgarrow jgarrow merged commit 55d57b3 into main Aug 19, 2022
@jgarrow jgarrow deleted the jg/remove-highlight-comments-clipboard branch August 19, 2022 18:10
@github-actions github-actions bot mentioned this pull request Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants