Fix npm audit vulnerabilities and update to @emotion#103
Closed
JEStaubach wants to merge 4 commits intoapollographql:masterfrom
Closed
Fix npm audit vulnerabilities and update to @emotion#103JEStaubach wants to merge 4 commits intoapollographql:masterfrom
JEStaubach wants to merge 4 commits intoapollographql:masterfrom
Conversation
package*.json Fixes apollographql#75 deprecated version of kleur via npm audit fixes. datasources/user.js Fixes apollographql#62 is breaking when this.context.user is undefined. It is unclear why this only showed up after updating dependencies...
audit fix dependencies for start client and server replace react-emtion with @emotion
Handle when context.user.id is undefined and userId which is no longer used.
JEStaubach
changed the title
Token is only being read on app start and if not present it doesn't get included in then authentication header even after logging in. So changed it to use middleware as described here: https://www.apollographql.com/docs/react/networking/network-layer/
Contributor
|
Thanks for this contribution! I'm handling this in update in #296 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package*.json
Fixes #75 deprecated version of kleur via npm audit fixes.
datasources/user.js
Fixes #62 is breaking when this.context.user is undefined. It
is unclear why this only showed up after updating dependencies...