[icxtunnel] add connect command and begin fleshing out routers #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyevsky
approved these changes
Sep 11, 2025
| } | ||
| defer client.Close() | ||
|
|
||
| connectResp, err := client.Connect(cmd.Context()) |
Contributor
There was a problem hiding this comment.
Where do we handle redundant connections? Inside client?
Collaborator
Author
There was a problem hiding this comment.
You know I'd totally overlooked this, I had this broken mental model that one process -> one connection. But looking at the QUIC code I realize this was incorrect.
Thankfully icx internally has support for cryptokey routing (ala allowedips) so supporting multiple redundant connections for a single handler is really straight forward (just register a new virtual network for each with the assigned ip ranges).
Thankfully no need for seperate muxers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some work to be done in the netlink router but the basics are coming together.