Check to clear metrics if 0 replicas #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 34.71% 36.54% +1.83%
==========================================
Files 15 15
Lines 386 394 +8
==========================================
+ Hits 134 144 +10
+ Misses 231 230 -1
+ Partials 21 20 -1
|
Contributor
Author
|
/assign @rrati |
rrati
reviewed
Nov 4, 2021
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
rrati
suggested changes
Nov 8, 2021
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
…h new changes Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
Signed-off-by: npecka <zangoose107@gmail.com>
rrati
reviewed
Nov 18, 2021
Signed-off-by: npecka <zangoose107@gmail.com>
npecka
changed the title
bkez322
reviewed
Nov 22, 2021
Contributor
|
Asked a question about the assumption we're making with deployments and the If we plan on assuming that objects with a |
rrati
reviewed
Nov 29, 2021
Signed-off-by: npecka <zangoose107@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: npecka, rrati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added condition where no validations are run and metrics cleared if object is found to have replica count of 0