Skip to content

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Sep 19, 2023

Now when the config with include is in place, there's no need to disable any incompatible checks.

@codecov-commenter
Copy link

Codecov Report

Merging #275 (64d0e93) into master (7d40738) will decrease coverage by 0.32%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   44.02%   43.71%   -0.32%     
==========================================
  Files          25       25              
  Lines        1129     1121       -8     
==========================================
- Hits          497      490       -7     
+ Misses        600      599       -1     
  Partials       32       32              
Files Changed Coverage Δ
pkg/validations/utils.go 71.73% <ø> (+1.52%) ⬆️
pkg/validations/validation_engine.go 82.35% <ø> (-0.78%) ⬇️

Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 918df87 into app-sre:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants