Skip to content

Conversation

@rluders
Copy link
Contributor

@rluders rluders commented Nov 29, 2023

Fixes this message:

pkg/validations/validation_engine_test.go:261:31: G601: Implicit memory aliasing in for loop. (gosec)
                        deployment.Spec.Replicas = &tt.updatedReplicaCount
                                                   ^
pkg/validations/validation_engine_test.go:275:32: G601: Implicit memory aliasing in for loop. (gosec)
                                deployment.Spec.Replicas = &tt.initialReplicaCount
                                                           ^

@openshift-ci openshift-ci bot requested review from ncaak and tremes November 29, 2023 09:37
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 95dd89e into app-sre:master Nov 29, 2023
@rluders rluders deleted the test/fix-gosec-implicit-memory branch November 29, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants