DVO-176: Add benchmark with adjusting deployments #295
Conversation
|
@ncaak: This pull request references DVO-176 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
=======================================
Coverage 44.32% 44.32%
=======================================
Files 25 25
Lines 1155 1155
=======================================
Hits 512 512
Misses 616 616
Partials 27 27 |
|
TODO: Add documentation about results |
| // Benchmark | ||
| for i := 0; i < b.N; i++ { | ||
| ch := make(chan groupOfObjects, channelBuffer) | ||
| go gr.groupAppObjects(context.Background(), namespace, ch) |
There was a problem hiding this comment.
I am not sure how reliable it is to spawn new go routines in a benchmark test.
|
/lgtm |
4 participants
No description provided.