Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Jan 11, 2024

summary

Added notes about kube-linter specific resource ignoring feature

misc

Updated kube-linter library to v0.6.5

tracks

https://issues.redhat.com/browse/DVO-66

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 11, 2024

@ncaak: This pull request references DVO-66 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

summary

Added notes about kube-linter specific resource ignoring feature

misc

Updated kube-linter library to v0.6.5

tracks

https://issues.redhat.com/browse/DVO-66

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rluders and tremes January 11, 2024 15:19
@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncaak
Copy link
Contributor Author

ncaak commented Jan 12, 2024

/retest

README.md Outdated

#### Ignore specific resources

It is possible to ignore certain resources from any or all validations. This is achieved by adding annotations to the resources we want DVO to ignore.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe better to use exclude instead of ignore? (in the first sentence)

@tremes
Copy link
Contributor

tremes commented Jan 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 994d397 into app-sre:master Jan 12, 2024
@ncaak ncaak deleted the DVO-66/checks-ignore-doc-update branch February 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants