Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Mar 7, 2024

summary

  • reverts change that was causing problems of endless loop and some routines being stale

misc

  • reverted some side-changes that could cause some errors after the revert
  • it changes this → commit
  • tracks DVO-191

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 7, 2024

@ncaak: This pull request references DVO-191 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

summary

  • reverts change that was causing problems of endless loop and some routines being stale

misc

  • reverted some side-changes that could cause some errors after the revert
  • it changes this → commit
  • tracks DVO-191

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 7, 2024

@ncaak: This pull request references DVO-191 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

summary

  • reverts change that was causing problems of endless loop and some routines being stale

misc

  • reverted some side-changes that could cause some errors after the revert
  • it changes this → commit
  • tracks DVO-191

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 7, 2024
@ncaak ncaak marked this pull request as ready for review March 7, 2024 17:30
@openshift-ci openshift-ci bot requested review from JoaoFula and rluders March 7, 2024 17:30
@ncaak
Copy link
Contributor Author

ncaak commented Mar 8, 2024

/retest

2 similar comments
@ncaak
Copy link
Contributor Author

ncaak commented Mar 8, 2024

/retest

@tremes
Copy link
Contributor

tremes commented Mar 11, 2024

/retest

@tremes
Copy link
Contributor

tremes commented Mar 11, 2024

/test lint

1 similar comment
@ncaak
Copy link
Contributor Author

ncaak commented Mar 11, 2024

/test lint

@tremes
Copy link
Contributor

tremes commented Mar 12, 2024

/retest

@tremes
Copy link
Contributor

tremes commented Mar 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e6ccdad into app-sre:master Mar 12, 2024
@ncaak ncaak deleted the DVO-191/quickfix-revert-threading branch February 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants