DVO-185: bugfixed persisting metrics after namespace recreation

[ncaak]

summary

Basically, the original object's namespace ID is now included as part of the cache key. This ensures that when the code finishes and starts deleting non-existent objects, it successfully recognises the past objects and then removes the metrics associated with them.

Previously, the namespace ID for these objects was captured by the currently recreated namespace. This way there was no way for the code to remove metrics created with the previous namespace ID, even if it recognised the objects as removable.

fixes

• Changed some function signatures to make the current namespace ID handle cache keys correctly.
• Changed existing unit tests using these functions to work properly with the new signature
• Minor fixes due to linting

in-progress

• Addition of new unit test for this specific case (recreated namespaces)

[openshift-ci-robot]

@ncaak: This pull request references DVO-185 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

This is a draft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@ncaak: This pull request references DVO-185 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Summary

Basically, the original object's namespace ID is now included as part of the cache key. This ensures that when the code finishes and starts deleting non-existent objects, it successfully recognises the past objects and then removes the metrics associated with them.

Previously, the namespace ID for these objects was captured by the currently recreated namespace. This way there was no way for the code to remove metrics created with the previous namespace ID, even if it recognised the objects as removable.

Fixes

• Changed some function signatures to make the current namespace ID handle cache keys correctly.
• Changed existing unit tests using these functions to work properly with the new signature
• Minor fixes due to linting

in-progress

• Addition of new unit test for this specific case (recreated namespaces)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ncaak: This pull request references DVO-185 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

summary

Basically, the original object's namespace ID is now included as part of the cache key. This ensures that when the code finishes and starts deleting non-existent objects, it successfully recognises the past objects and then removes the metrics associated with them.

Previously, the namespace ID for these objects was captured by the currently recreated namespace. This way there was no way for the code to remove metrics created with the previous namespace ID, even if it recognised the objects as removable.

fixes

• Changed some function signatures to make the current namespace ID handle cache keys correctly.
• Changed existing unit tests using these functions to work properly with the new signature
• Minor fixes due to linting

in-progress

• Addition of new unit test for this specific case (recreated namespaces)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ncaak]

/test lint

[ncaak]

/test lint

[ncaak]

/test lint

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.24%. Comparing base (e3351d0) to head (4d88ff3).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   55.24%   55.24%           
=======================================
  Files          15       15           
  Lines         905      905           
=======================================
  Hits          500      500           
  Misses        375      375           
  Partials       30       30           

Files	Coverage Δ
pkg/controller/validationscache.go	100.00% <100.00%> (ø)
pkg/controller/generic_reconciler.go	60.67% <87.50%> (-0.19%)	⬇️

[ncaak]

/retest

[ncaak]

/test ci/prow/deployment-validation-operator-e2e-tests

[openshift-ci]

@ncaak: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test ci-index-dvo-operator-bundle
• /test coverage
• /test deployment-validation-operator-e2e-tests
• /test images
• /test lint
• /test test
• /test validate

Use /test all to run all jobs.

In response to this:

/test ci/prow/deployment-validation-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ncaak]

/test deployment-validation-operator-e2e-tests

[ncaak]

/retest

[rluders]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncaak,rluders]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ncaak]

/retest