Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Apr 16, 2024

summary

All log lines that were not important enough were moved to debug level. Since this could affect support and debugging of the program, and it's still not configurable, the log level was raised to debug to maintain roughly the same behavior.
Some lines have been reworked or simplified to improve readability, including some error log lines.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 16, 2024

@ncaak: This pull request references DVO-203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

summary

All log lines that were not important enough were moved to debug level. Since this could affect support and debugging of the program, and it's still not configurable, the log level was raised to debug to maintain roughly the same behavior.
Some lines have been reworked or simplified to improve readability, including some error log lines.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Apr 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncaak ncaak force-pushed the DVO-203/revamp-logging branch from 8472472 to 31cb3ca Compare April 19, 2024 09:12
@ncaak ncaak marked this pull request as ready for review April 19, 2024 09:13
@openshift-ci openshift-ci bot requested review from JoaoFula and rluders April 19, 2024 09:13
@JoaoFula
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3eebf29 into app-sre:master Apr 19, 2024
@ncaak ncaak deleted the DVO-203/revamp-logging branch February 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants