Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Oct 8, 2024

summary

  • Fixed build_tag script for the Jenkins job that builds from git tags
  • Added new targets to Makefile to properly build the bundle and the catalog images from master branch
  • Added some scripts to help with the building process and install dependencies on the Jenkins job's scope

constraints

  • Some parts need refining (e.g. cleaning testing codes) but it's enough for review so far. The PR starts as draft and will be moved to a "ready for review" status when updated with the definitive version.

@ncaak ncaak marked this pull request as ready for review October 14, 2024 13:22
@openshift-ci openshift-ci bot requested review from JoaoFula and tremes October 14, 2024 13:22
@tremes
Copy link
Contributor

tremes commented Oct 14, 2024

I reviewed and only tried few basic commands. Thanks!
/lgtm

@ncaak
Copy link
Contributor Author

ncaak commented Oct 16, 2024

/hold

@ncaak
Copy link
Contributor Author

ncaak commented Oct 16, 2024

/test ci/prow/coverage

@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2024

@ncaak: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-index-dvo-operator-bundle
  • /test coverage
  • /test deployment-validation-operator-e2e-tests
  • /test images
  • /test lint
  • /test test
  • /test validate

Use /test all to run all jobs.

In response to this:

/test ci/prow/coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ncaak
Copy link
Contributor Author

ncaak commented Oct 16, 2024

/test coverage

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (f848b52) to head (97c19ac).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

@ncaak
Copy link
Contributor Author

ncaak commented Oct 18, 2024

/test validate

@tremes
Copy link
Contributor

tremes commented Oct 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2024
@ncaak ncaak merged commit 411250a into app-sre:master Oct 21, 2024
7 of 9 checks passed
@ncaak ncaak deleted the DVO-228/fix-makefile-for-build-tag-job branch February 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants