Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Oct 22, 2024

summary

  • Removed outdated files
  • Removed test Dockerfile
  • Fixed some README file annotations

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 22, 2024

@ncaak: An error was encountered searching for bug DVO-228 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 401:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

summary

  • Removed outdated files
  • Removed test Dockerfile
  • Fixed some README file annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JoaoFula and tremes October 22, 2024 08:53
@openshift-ci
Copy link

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Contributor

tremes commented Oct 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 22, 2024
@ncaak ncaak merged commit 20fba05 into app-sre:master Oct 22, 2024
7 of 9 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (2bb5647) to head (b9259d6).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

@ncaak ncaak deleted the DVO-228/clean-boilerplate-dependency branch February 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants