Skip to content

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Nov 6, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from JoaoFula and ncaak November 6, 2024 11:49
@openshift-ci openshift-ci bot added the approved label Nov 6, 2024
@tremes
Copy link
Contributor Author

tremes commented Nov 6, 2024

/test deployment-validation-operator-e2e-tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (d8b30d4) to head (c9cfb4f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

@ncaak
Copy link
Contributor

ncaak commented Nov 14, 2024

ultra-minor change:
As we changed the commands, let's change the comment to be clean.
line 102

@ncaak
Copy link
Contributor

ncaak commented Nov 14, 2024

/lgtm

return 1
fi
log "Building the catalog image"
${CONTAINER_ENGINE} build -f olm/catalog.Dockerfile -t $(OLM_CATALOG_IMAGE_VERSION)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(OLM_CATALOG_IMAGE_VERSION) tries to run it as a command. I needed to change it to ${OLM_CATALOG_IMAGE_VERSION} with curly brackets for it to work

@openshift-ci
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1ac2a44 into app-sre:master Nov 14, 2024
9 checks passed
tremes added a commit to tremes/deployment-validation-operator that referenced this pull request Nov 15, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants