-
Notifications
You must be signed in to change notification settings - Fork 49
Migrate to file based catalog #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/test deployment-validation-operator-e2e-tests |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. |
|
ultra-minor change: |
|
/lgtm |
build/build_opm_catalog.sh
Outdated
| return 1 | ||
| fi | ||
| log "Building the catalog image" | ||
| ${CONTAINER_ENGINE} build -f olm/catalog.Dockerfile -t $(OLM_CATALOG_IMAGE_VERSION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$(OLM_CATALOG_IMAGE_VERSION) tries to run it as a command. I needed to change it to ${OLM_CATALOG_IMAGE_VERSION} with curly brackets for it to work
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 1ac2a44.
No description provided.