Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Jan 30, 2025

summary

Updated some libraries that were triggering some errors on external validators

@openshift-ci-robot
Copy link
Collaborator

@ncaak: This pull request explicitly references no jira issue.

In response to this:

summary

Updated some libraries that were triggering some errors on external validators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JoaoFula and tremes January 30, 2025 17:05
@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncaak
Copy link
Contributor Author

ncaak commented Jan 30, 2025

/hold

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (b861dee) to head (41ad238).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

@tremes
Copy link
Contributor

tremes commented Jan 31, 2025

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Jan 31, 2025
@ncaak ncaak force-pushed the maintenance/upgrade-images branch from 81b4e1c to 50c47d3 Compare February 4, 2025 15:30
@ncaak
Copy link
Contributor Author

ncaak commented Feb 6, 2025

/unhold

@tremes
Copy link
Contributor

tremes commented Feb 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8c666cd into app-sre:master Feb 7, 2025
10 checks passed
@ncaak ncaak deleted the maintenance/upgrade-images branch February 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants