Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Feb 6, 2025

summary

Added some manifests to be used on the Konflux CLI to help releasing a new version (currently only staging)

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 6, 2025

@ncaak: This pull request references DVO-213 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

summary

Added some manifests to be used on the Konflux CLI to help releasing a new version (currently only staging)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JoaoFula and tremes February 6, 2025 13:57
@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (b861dee) to head (58137a4).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

apiVersion: appstudio.redhat.com/v1alpha1
kind: Release
metadata:
name: staging-release-test-pxmtl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary name? I am wondering if the test-pxmtl suffix makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the file is a stub, I usually match the suffix with the one from the snapshot. That's why it looks arbitrary. As this is applied in the cluster directly there is no way of creating another entity with the same name (the system won't let you).
I included them in the repo to have this work saved somewhere, despite the fact that we will need to change the image digests and the names when we properly release it on prod.

@tremes
Copy link
Contributor

tremes commented Feb 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b82ff04 into app-sre:master Feb 7, 2025
9 checks passed
@ncaak ncaak deleted the DVO-213/add-staging-manifests branch February 7, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants