-
Notifications
You must be signed in to change notification settings - Fork 49
DVO-213: add staging manifests #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVO-213: add staging manifests #417
Conversation
|
@ncaak: This pull request references DVO-213 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. |
| apiVersion: appstudio.redhat.com/v1alpha1 | ||
| kind: Release | ||
| metadata: | ||
| name: staging-release-test-pxmtl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a temporary name? I am wondering if the test-pxmtl suffix makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the file is a stub, I usually match the suffix with the one from the snapshot. That's why it looks arbitrary. As this is applied in the cluster directly there is no way of creating another entity with the same name (the system won't let you).
I included them in the repo to have this work saved somewhere, despite the fact that we will need to change the image digests and the names when we properly release it on prod.
|
/lgtm |
summary
Added some manifests to be used on the Konflux CLI to help releasing a new version (currently only staging)