Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Feb 6, 2025

summary

Updated the base image used as builder for the operator Dockerfile.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 6, 2025

@ncaak: This pull request references DVO-241 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

summary

Updated the base image used as builder for the operator Dockerfile.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 6, 2025
@ncaak ncaak force-pushed the DVO-241/replace-dockerfile-builder-image branch from 641f5d6 to 7fb3ae8 Compare February 7, 2025 14:41
@ncaak ncaak marked this pull request as ready for review February 7, 2025 15:24
@openshift-ci openshift-ci bot requested review from JoaoFula and tremes February 7, 2025 15:24
@ncaak
Copy link
Contributor Author

ncaak commented Feb 7, 2025

/test deployment-validation-operator-e2e-tests

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (3fc6a44) to head (5428a42).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

@ncaak
Copy link
Contributor Author

ncaak commented Feb 10, 2025

/test deployment-validation-operator-e2e-tests

1 similar comment
@BaiyangZhou
Copy link
Contributor

/test deployment-validation-operator-e2e-tests

@ncaak
Copy link
Contributor Author

ncaak commented Feb 11, 2025

/hold

@ncaak
Copy link
Contributor Author

ncaak commented Feb 11, 2025

/unhold

@BaiyangZhou
Copy link
Contributor

/test deployment-validation-operator-e2e-tests

1 similar comment
@ncaak
Copy link
Contributor Author

ncaak commented Feb 13, 2025

/test deployment-validation-operator-e2e-tests

@ncaak ncaak force-pushed the DVO-241/replace-dockerfile-builder-image branch from b894e72 to 7215dd1 Compare February 19, 2025 11:55
@tremes
Copy link
Contributor

tremes commented Feb 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4377ff2 into app-sre:master Feb 24, 2025
9 checks passed
@ncaak ncaak deleted the DVO-241/replace-dockerfile-builder-image branch November 13, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants