Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Feb 14, 2025

No description provided.

@openshift-ci-robot
Copy link
Collaborator

@ncaak: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from BaiyangZhou and tremes February 14, 2025 12:22
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncaak
Copy link
Contributor Author

ncaak commented Feb 14, 2025

/hold

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (3fc6a44) to head (fb294e9).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

@opokornyy
Copy link
Collaborator

/lgtm

@ncaak ncaak force-pushed the konflux/update-labels-annotations branch from 5b04b88 to fb294e9 Compare February 14, 2025 15:20
@openshift-ci openshift-ci bot removed the lgtm label Feb 14, 2025
@ncaak
Copy link
Contributor Author

ncaak commented Feb 14, 2025

/unhold

@opokornyy
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 17, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 27f50d9 into app-sre:master Feb 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants