Skip to content

feat: add billing#10

Merged
siddharthlatest merged 5 commits intofeat/es7from
feat/arc_billing
Jul 28, 2019
Merged

feat: add billing#10
siddharthlatest merged 5 commits intofeat/es7from
feat/arc_billing

Conversation

@bietkul
Copy link
Copy Markdown

@bietkul bietkul commented Jul 19, 2019

What does this do / why do we need it?

What should your reviewer look out for in this PR?

Do you need help or clarification on anything?

Which issue(s) does this PR fix?

@bietkul bietkul requested review from bsrk and siddharthlatest July 19, 2019 16:21
Copy link
Copy Markdown
Member

@siddharthlatest siddharthlatest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor formatting changes can help. Overall looks good (y)

Comment thread main.go Outdated
Comment thread main.go Outdated
Comment thread util/billing.go Outdated
Comment thread util/billing.go Outdated
Comment thread util/billing.go Outdated
Comment thread util/billing.go Outdated
Comment thread util/billing.go Outdated
Comment thread util/billing.go Outdated
Comment thread util/billing.go Outdated
Copy link
Copy Markdown
Member

@siddharthlatest siddharthlatest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (y)

@siddharthlatest siddharthlatest merged commit d4dacc7 into feat/es7 Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants